Mule doesn't start the actual JMS connection

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: To be reviewed To be reviewed
  • Resolution: Won't Fix or Usage Issue
  • Affects Version/s: 2.0.2
  • Fix Version/s: None
  • Component/s: Transport: JMS
  • Labels:
    None
  • Environment:

    Linux Ubuntu 8.04, i386, Java 6

  • User impact:
    Low
  • Similar Issues:
    None

Description

Mule doesn't actually seem to start the JMS connection to the broker. This is caused by the following code in JMSConnector:

connection = createConnection();
if (!started.get())
{
connection.start();
}

  1. Text File
    JmsConnector.patch
    21/Jul/08 04:32 PM
    0.4 kB
    Jeroen Benckhuijsen

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jeroen Benckhuijsen added a comment -

Patch fixing the issue

Show
Jeroen Benckhuijsen added a comment - Patch fixing the issue
Hide
Permalink
Andrew Perepelytsya added a comment -

Jeroen, could you please provide more info? After reviewing the code it doesn't look like a problem to me, the connection is started in the doStart() method.

Show
Andrew Perepelytsya added a comment - Jeroen, could you please provide more info? After reviewing the code it doesn't look like a problem to me, the connection is started in the doStart() method.
Hide
Permalink
Jeroen Benckhuijsen added a comment -

Andrew, doStart() indeeds does the starting already, Therefore, it's just a minor issue as the original code tries to start an already started connection. However, the code is a bit strange, so this fix is just for clarity (i.e. only start the connection is it HASN'T been started already).

Original: if (started.get())
New: if (!started.get()) <-- Mind the !

Show
Jeroen Benckhuijsen added a comment - Andrew, doStart() indeeds does the starting already, Therefore, it's just a minor issue as the original code tries to start an already started connection. However, the code is a bit strange, so this fix is just for clarity (i.e. only start the connection is it HASN'T been started already). Original: if (started.get()) New: if (!started.get()) <-- Mind the !
Hide
Permalink
Andrew Perepelytsya added a comment -

The 'started' variable refers to the JmsConnector, and not the connection itself. While their lifecycles mostly match, they are not guaranteed to be always the same.

Show
Andrew Perepelytsya added a comment - The 'started' variable refers to the JmsConnector, and not the connection itself. While their lifecycles mostly match, they are not guaranteed to be always the same.

People

  • Assignee:
    Andrew Perepelytsya
    Reporter:
    Jeroen Benckhuijsen
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: