Connector workManager's should be disposed in stop phase before transport itself is stopped.

Details

  • User impact:
    High
  • Log Output:
    Hide
    [03-11 23:13:28] ERROR DefaultExceptionStrategy [jmsConnector.dispatcher.7]: Caught exception in Exception Strategy: The producer is closed
    javax.jms.IllegalStateException: The producer is closed
    at org.apache.activemq.ActiveMQMessageProducer.checkClosed(ActiveMQMessageProducer.java:333)
    at org.apache.activemq.ActiveMQMessageProducer.getDestination(ActiveMQMessageProducer.java:297)
    at org.apache.activemq.ActiveMQMessageProducer.send(ActiveMQMessageProducer.java:384)
    at org.mule.transport.jms.Jms102bSupport.send(Jms102bSupport.java:244)
    at org.mule.transport.jms.JmsMessageDispatcher.dispatchMessage(JmsMessageDispatcher.java:219)
    at org.mule.transport.jms.JmsMessageDispatcher.doDispatch(JmsMessageDispatcher.java:72)
    at org.mule.transport.AbstractMessageDispatcher$Worker.run(AbstractMessageDispatcher.java:262)
    at org.mule.work.WorkerContext.run(WorkerContext.java:310)
    at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1061)
    at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:575)
    at java.lang.Thread.run(Thread.java:613)

    Show
    [03-11 23:13:28] ERROR DefaultExceptionStrategy [jmsConnector.dispatcher.7]: Caught exception in Exception Strategy: The producer is closed javax.jms.IllegalStateException: The producer is closed at org.apache.activemq.ActiveMQMessageProducer.checkClosed(ActiveMQMessageProducer.java:333) at org.apache.activemq.ActiveMQMessageProducer.getDestination(ActiveMQMessageProducer.java:297) at org.apache.activemq.ActiveMQMessageProducer.send(ActiveMQMessageProducer.java:384) at org.mule.transport.jms.Jms102bSupport.send(Jms102bSupport.java:244) at org.mule.transport.jms.JmsMessageDispatcher.dispatchMessage(JmsMessageDispatcher.java:219) at org.mule.transport.jms.JmsMessageDispatcher.doDispatch(JmsMessageDispatcher.java:72) at org.mule.transport.AbstractMessageDispatcher$Worker.run(AbstractMessageDispatcher.java:262) at org.mule.work.WorkerContext.run(WorkerContext.java:310) at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1061) at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:575) at java.lang.Thread.run(Thread.java:613)
  • Similar Issues:
    None

Description

Disposal of the workManagers in stop() before the transport itself has been stopped allows jobs to complete and dispatch before the transport is stopped. Currently messages randomly get lost (based on timing) with errors because there are still pending dispatcher jobs when the transport implementation is stopped.

Example of error is shown below.

Issue Links

blocks

Bug - A problem which impairs or prevents the functions of the product. MULE-4259 NullPointerException in CxfMessageDispatcher when executing loanbroker [cxf, asynchrounous] for 100 requests

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is blocked by

Bug - A problem which impairs or prevents the functions of the product. MULE-4268 Retry should not stop/start connector

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Task - A task that needs to be done. MULE-3679 Review connector lifecyle

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MULE-4269 Message are lost between connector stop and dispose when dispatcher thread pool is used

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Daniel Feist added a comment -

This fix correct things, but if for some reason someone tries to send a message when connecter has been stopped this will result in a NullPointerException.

This wouldn't happen if it wasn't for MULE-4254, but we need to decide if we want to fix MULE-4254 across the board or only in/for transport where the concept of start/stop applies.

Show
Daniel Feist added a comment - This fix correct things, but if for some reason someone tries to send a message when connecter has been stopped this will result in a NullPointerException. This wouldn't happen if it wasn't for MULE-4254, but we need to decide if we want to fix MULE-4254 across the board or only in/for transport where the concept of start/stop applies.
Hide
Permalink
Daniel Feist added a comment -

This will need to be fixed properly in 3.0. For 2.2 we can implement some workarounds so that retry is not affected by this fix.

Show
Daniel Feist added a comment - This will need to be fixed properly in 3.0. For 2.2 we can implement some workarounds so that retry is not affected by this fix.

People

  • Assignee:
    Travis Carlson
    Reporter:
    Daniel Feist
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: