NotificationManager should skip duplicate registrations with a warning

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 3.0.0-M1
  • Fix Version/s: ITR30, 3.0.0-M2
  • Component/s: Core: Lifecycle
  • Labels:
    None
  • User impact:
    Medium
  • Similar Issues:
    None

Description

A duplicate registration is when the exact same instance is registered twice:

MyListener listener = new MyListener();
muleContext.registerListener(listener);
muleContext.registerListener(listener);

This should result in listener being invoked once and not twice as it is currently, for the notification it is listening to.

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. MULE-4796 CxfServiceComponent services are initialized/started twice because of duplicate notifications

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MULE-4808 NotificationsListeners registered before xml configuration is parsed end up being registered twice.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Perepelytsya added a comment -

Dan, could you please provide more context when filing issues? What is considered a duplicate registration? How do you define uniqueness?

Show
Andrew Perepelytsya added a comment - Dan, could you please provide more context when filing issues? What is considered a duplicate registration? How do you define uniqueness?
Daniel Feist made changes -
Field Original Value New Value
Description A duplicate registration is when the exact same instance is registered twice:

MyListener listener = new MyListener();
muleContext.registerListener(listener);
muleContext.registerListener(listener);
Daniel Feist made changes -
Link This issue relates to MULE-4796 [ MULE-4796 ]
Daniel Feist made changes -
Description A duplicate registration is when the exact same instance is registered twice:

MyListener listener = new MyListener();
muleContext.registerListener(listener);
muleContext.registerListener(listener); 		A duplicate registration is when the exact same instance is registered twice:

MyListener listener = new MyListener();
muleContext.registerListener(listener);
muleContext.registerListener(listener);

This should result in {{listener}} being invoked once and not twice as it is currently, for the notification it is listening to.
Daniel Feist made changes -
Fix Version/s Tech. Debt [ 10572 ]
Priority To be reviewed [ 6 ] Minor [ 4 ]
Hide
Permalink
Dirk Olmes added a comment -

See the issue's description. Registring the same object as listener should warn and do not perform the registration twice.

I'd do the comparison using equals and not by checking with ==.

Show
Dirk Olmes added a comment - See the issue's description. Registring the same object as listener should warn and do not perform the registration twice. I'd do the comparison using equals and not by checking with ==.
Hide
Permalink
Daniel Feist added a comment -

I agree about using equals. Having thought about it a but more i think notification listener uniqueness should also include the subscription, as you may want to register the same listener with different subscriptions.

The implementation of this is in fact very easy; just implement equals in ListenerSubscriptionPair.

Show
Daniel Feist added a comment - I agree about using equals. Having thought about it a but more i think notification listener uniqueness should also include the subscription, as you may want to register the same listener with different subscriptions. The implementation of this is in fact very easy; just implement equals in ListenerSubscriptionPair.
Daniel Feist made changes -
Assignee Daniel Feist [ dfeist ]
Daniel Feist made changes -
Status Open [ 1 ] Closed [ 6 ]
Fix Version/s 3.0.0-M2 [ 10653 ]
Fix Version/s Tech. Debt [ 10572 ]
Resolution Fixed [ 1 ]
Daniel Feist made changes -
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Daniel Feist made changes -
Status Reopened [ 4 ] Closed [ 6 ]
Fix Version/s ITR30 [ 10815 ]
Resolution Fixed [ 1 ]
Daniel Feist made changes -
Link This issue relates to MULE-4808 [ MULE-4808 ]
Transition Time In Source Status Execution Times Last Executer Last Execution Date
Open Open Closed Closed
2d 12h 9m 1 Daniel Feist 21/Mar/10 09:28 PM
Closed Closed Reopened Reopened
10h 27m 1 Daniel Feist 22/Mar/10 07:55 AM
Reopened Reopened Closed Closed
19s 1 Daniel Feist 22/Mar/10 07:56 AM
This list may be incomplete, as errors occurred whilst retrieving source from linked applications:
  • Repository mule on http://foo.bar/ failed: Error in remote call to 'FishEye 0 (http://foo.bar/)' (http://foo.bar) [AbstractRestCommand{path='/rest-service-fe/changeset-v1/listChangesets/', params={expand=changesets[-21:-1].revisions[0:29], comment=MULE-4800, p4JobFixed=MULE-4800, rep=mule}, methodType=GET}] : java.net.UnknownHostException: foo.bar

People

  • Assignee:
    Daniel Feist
    Reporter:
    Daniel Feist
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: