FtpConnectionFactory does not properly validate connections

Details

  • User impact:
    Medium
  • Similar Issues:
    None

Description

The validateObject method relies on an exception to be thrown to determine validity. The noop command can return a negative result without an exception.

FtpConnectionFactory.java:64
public boolean validateObject(Object obj)
    {
        FTPClient client = (FTPClient) obj;
        try
        {
            client.sendNoOp();
            return true;
        }
        catch (IOException e)
        {
            return false;
        }
    }

A possible fix would be to return the result of the noop command instead of returning true.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dirk Olmes added a comment -

2.2.x: http://fisheye.codehaus.org/changelog/mule/?cs=19992

Show
Dirk Olmes added a comment - 2.2.x: http://fisheye.codehaus.org/changelog/mule/?cs=19992
Hide
Permalink
Arne Seime added a comment -

Some servers return messages like "500 User Exit denies Userid 'YYYYYYY' from using Command 'NOOP'.", which renders the validateObject method above unusable (always returns false)

Example FileZilla log from a very restrictive FTP server setup:

Status:	Connecting to XXX.XXX.XX.XX:21...
Status:	Connection established, waiting for welcome message...
Response:	220-FTPD1 IBM FTP CS V1R12 at XYZ.COM, 14:17:26 on 2012-01-13.
Response:	220 Connection will close if idle for more than 5 minutes.
Command:	USER YYYYYY
Response:	331 Send password please.
Command:	PASS ******
Response:	230 YYYYYY is logged on.  Working directory is "/XXXX/YYYY".
Command:	SYST
Response:	215 UNIX is the operating system of this server. FTP Server is running on z/OS.
Command:	FEAT
Response:	500 User Exit denies Userid 'YYYYYY' from using Command 'FEAT'.
Status:	Connected

Maybe a solution could be to try to resend login credentials (or some other "dummy" command) in case sendNoop() returns false but no exception is thrown?

Show
Arne Seime added a comment - Some servers return messages like "500 User Exit denies Userid 'YYYYYYY' from using Command 'NOOP'.", which renders the validateObject method above unusable (always returns false) Example FileZilla log from a very restrictive FTP server setup: 
Status:	Connecting to XXX.XXX.XX.XX:21...
Status:	Connection established, waiting for welcome message...
Response:	220-FTPD1 IBM FTP CS V1R12 at XYZ.COM, 14:17:26 on 2012-01-13.
Response:	220 Connection will close if idle for more than 5 minutes.
Command:	USER YYYYYY
Response:	331 Send password please.
Command:	PASS ******
Response:	230 YYYYYY is logged on.  Working directory is "/XXXX/YYYY".
Command:	SYST
Response:	215 UNIX is the operating system of this server. FTP Server is running on z/OS.
Command:	FEAT
Response:	500 User Exit denies Userid 'YYYYYY' from using Command 'FEAT'.
Status:	Connected
Maybe a solution could be to try to resend login credentials (or some other "dummy" command) in case sendNoop() returns false but no exception is thrown?

People

  • Assignee:
    Dirk Olmes
    Reporter:
    Mike Cantrell
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: