Inbound property scope must be read-only

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 3.2.1
  • Fix Version/s: Tech. Debt
  • Component/s: Core: API, Core: Properties
  • Labels:
    None
  • User impact:
    Low
  • Affects Docs:
    Yes
  • Migration Impact:
    None since inbound scope was read only previously, but we must make sure it is documented
  • Similar Issues:
    None

Description

There is no reason for INBOUND scope to be read/write. AP use this issue to track the areas that need to be addressed, but we can't go GA with this behaviour change.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ross Mason added a comment -

There is a test DefaultMuleMessageTestCase with a fixture called clearProperties. Can you add the following when fixing this issue:

>> +// try
>> +// { >> +// payload.clearProperties(PropertyScope.INBOUND); >> +// fail("inbound scope is read only"); >> +// }
>> +// catch (UnsupportedOperationException e)
>> +// { >> +// //expected >> +// }
>> +
>> + }

Show
Ross Mason added a comment - There is a test DefaultMuleMessageTestCase with a fixture called clearProperties. Can you add the following when fixing this issue: >> +// try >> +// { >> +// payload.clearProperties(PropertyScope.INBOUND); >> +// fail("inbound scope is read only"); >> +// } >> +// catch (UnsupportedOperationException e) >> +// { >> +// //expected >> +// } >> + >> + }
Hide
Permalink
Mike Schilling added a comment -

There are a number of places in the code (e.g. the Atom module) that modify Inbound properties long after the message is constructed. Removing all of them will be a project of at least a week.

Show
Mike Schilling added a comment - There are a number of places in the code (e.g. the Atom module) that modify Inbound properties long after the message is constructed. Removing all of them will be a project of at least a week.
Hide
Permalink
Daniel Feist added a comment -

Is there any way you can remove api to write to inbound scope and then still set them using some other mechanism e.g. casting to impl and using method in imp or something? Primarily so that users don't use the api.

Show
Daniel Feist added a comment - Is there any way you can remove api to write to inbound scope and then still set them using some other mechanism e.g. casting to impl and using method in imp or something? Primarily so that users don't use the api.
Hide
Permalink
Mike Schilling added a comment -

Addressed some API-ish issues with 19400. At least the API no longer encourage people to modify inbound properties

Show
Mike Schilling added a comment - Addressed some API-ish issues with 19400. At least the API no longer encourage people to modify inbound properties

People

  • Assignee:
    Daniel Feist
    Reporter:
    Ross Mason
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: