Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: 3.3 RC4
-
Component/s: Transport: HTTP(S) / Jetty
-
Labels:None
-
User impact:Very Low
-
Similar Issues:None
Description
validateHeader returns happily if the expected header is not present, which allows otherwise broken tests to pass.
I suggest to add a fail() statement at the end to solve this:
private void validateHeader(final Header[] headers, final String headerName, final String expectedValue) { for (final Header header : headers) { if (headerName.equals(header.getName())) { assertEquals(expectedValue, header.getValue()); return; } } fail(String.format("Didn't find header: %s=%s in headers: %s", headerName, expectedValue, headers)); }
Activity
Evangelina Martinez Ruiz Moreno
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Assignee | Evangelina Martinez Ruiz Moreno [ evangelinamrm ] |
Evangelina Martinez Ruiz Moreno
made changes -
| Priority | To be reviewed [ 6 ] | Critical [ 2 ] |
Evangelina Martinez Ruiz Moreno
made changes -
| Status | Open [ 1 ] | In Progress [ 3 ] |
Alejandro Sequeira
made changes -
| Affects Version/s | 3.3.0 [ 11110 ] | |
| Affects Version/s | 3.3 RC4 [ 11276 ] |
Evangelina Martinez Ruiz Moreno
made changes -
| Resolution | Fixed [ 1 ] | |
| Fix Version/s | 3.4.0 [ 11142 ] | |
| Fix Version/s | 3.3.0 [ 11110 ] | |
| Status | In Progress [ 3 ] | Closed [ 6 ] |