Mule
  1. Mule
  2. MULE-4137

Log4jNotificationLoggerAgent is useless

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.2
    • Fix Version/s: 3.0.0-RC3
    • Component/s: Core: Agents
    • Labels:
      None
    • User impact:
      Low
    • Similar Issues:
      MULE-4221AbstractAgent is useless for custom agents
      MULE-2939Acegi Authentication Namespace Test Useless
      MULE-7406New database: streaming is useless if statement fetch size is not configured
      MULE-3097Update the project wizard, the generated schema is incorrect
      MULE-4569CXF transport depend on CONTEXT_STARTED notification to start protocol endpoints
      MULE-504Remove pause and resume methods from the component
      MULE-7352Watermark should fail to start if update expression is not an expression
      MULE-4119Make JmsMessageRequester support expressions in selector
      MULE-7131MessageProcessorNotification is using flowConstruct.getName() as resource identifier.
      MULE-1232AbstractComponent.start() causes NPE (really ConcurrentModificationException) in model

      Description

      I don't see how its private attribute eventLogger could be something else than null with the big chunk of code commented out in doInitialise.

      Because it is null, logEvent does nothing.

      Could it be possible to uncomment these lines, until the OSGi/PAX quagmire is sorted out:

      else

      { /* ... */ eventLogger = Logger.getLogger(logName); /* ... */ }

      so at least a logger will be active?

      PS. That would also call for a review of getDescription, which does not acknowledge the fact a non-blank logName is an interesting configuration value.

        Activity

        Hide
        David Dossot added a comment -

        Could we please have this fixed for 3.x?

        Show
        David Dossot added a comment - Could we please have this fixed for 3.x?
        Show
        Dirk Olmes added a comment - http://fisheye.codehaus.org/changelog/mule/?cs=19354

          People

          • Assignee:
            David Dossot
            Reporter:
            David Dossot
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development