Mule
  1. Mule
  2. MULE-5862

SFTP-transport: upgrade Jsch dependency to jsch-0.1.45

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.2, 3.2.0
    • Fix Version/s: 3.5.0 M4
    • Component/s: Transport: FTP / SFTP
    • Labels:
      None
    • User impact:
      Medium
    • Similar Issues:
      MULE-6982Upgrade jsch to version 0.1.50
      MULE-7847Upgrade JSCH to version 0.151
      MULE-6288SFTP Transport does not restrict access to known hosts only [Jsch StrictHostKeyChecking=yes] option.
      MULE-7155Add appending support to the SFTP transport
      MULE-5308Upgrade Quartz dependency
      MULE-7951Upgrade test dependencies
      MULE-6767Ability to read files from recursive directories using File/Ftp/Sftp transport
      MULE-5226Create sftp transport
      MULE-6866Upgrade to Groovy 2.3.6
      MULE-6450SFTP transport does not URL encode attributes

      Description

      jsch-0.1.45 has a substantial performance fix:

      - change: increasing local window size for sftp get

      as well as other fixes, see:
      http://sourceforge.net/mailarchive/message.php?msg_id=28311193

        Activity

        Hide
        Dirk Olmes added a comment -

        Can you provide more feedback on this? Is this just a switch of dependency without any changes to the API required? Do all tests of the SFTP transport still run green with the upgraded dependency?

        Show
        Dirk Olmes added a comment - Can you provide more feedback on this? Is this just a switch of dependency without any changes to the API required? Do all tests of the SFTP transport still run green with the upgraded dependency?
        Hide
        Håkan Dahl added a comment -

        For mule-3.2.x a lot of tests are failing with:

        java.lang.ClassCastException: org.mule.construct.Flow cannot be cast to org.mule.api.service.Service
        	at org.mule.registry.MuleRegistryHelper.lookupService(MuleRegistryHelper.java:391)
        

        which is now fixed in 3.3.x.

        Results from running SFTP-transport tests with code from svn tag mule-3.3.0-RC1:

        1. without any changes

        Failed tests: 
          processFileOlderThanFileAge[0](org.mule.transport.sftp.SftpFileAgeFunctionalTestCase)
          processFileOlderThanFileAge[1](org.mule.transport.sftp.SftpFileAgeFunctionalTestCase)
        
        Tests run: 87, Failures: 2, Errors: 0, Skipped: 3
        

        2. with jsch 0.1.48 (latest release)
        Same result as in 1) where jsch-0.1.44-1 is used.

        Show
        Håkan Dahl added a comment - For mule-3.2.x a lot of tests are failing with: java.lang.ClassCastException: org.mule.construct.Flow cannot be cast to org.mule.api.service.Service at org.mule.registry.MuleRegistryHelper.lookupService(MuleRegistryHelper.java:391) which is now fixed in 3.3.x. Results from running SFTP-transport tests with code from svn tag mule-3.3.0-RC1: 1. without any changes Failed tests: processFileOlderThanFileAge[0](org.mule.transport.sftp.SftpFileAgeFunctionalTestCase) processFileOlderThanFileAge[1](org.mule.transport.sftp.SftpFileAgeFunctionalTestCase) Tests run: 87, Failures: 2, Errors: 0, Skipped: 3 2. with jsch 0.1.48 (latest release) Same result as in 1) where jsch-0.1.44-1 is used.
        Hide
        Håkan Dahl added a comment -

        Jsch-version in issue heading should be changed to jsch-0.1.48 instead of jsch-0.1.45.

        Show
        Håkan Dahl added a comment - Jsch-version in issue heading should be changed to jsch-0.1.48 instead of jsch-0.1.45.
        Hide
        Håkan Dahl added a comment -

        Also remove the (temporary) maven-repository from the SFTP-transport pom.xml, jsch-lib is now published to maven-central:

            <repositories>
                <repository>
                    <name>jsch</name>
                    <url>http://jsch.sourceforge.net/maven2/</url>
                    <id>jsch</id>
                </repository>
            </repositories>
        
        Show
        Håkan Dahl added a comment - Also remove the (temporary) maven-repository from the SFTP-transport pom.xml, jsch-lib is now published to maven-central: <repositories> <repository> <name>jsch</name> <url>http://jsch.sourceforge.net/maven2/</url> <id>jsch</id> </repository> </repositories>
        Hide
        Håkan Dahl added a comment -
        Show
        Håkan Dahl added a comment - Note problem introduced with jsch-0.1.48: http://www.mail-archive.com/jsch-users@lists.sourceforge.net/msg01634.html

          People

          • Assignee:
            Steven Camina
            Reporter:
            Håkan Dahl
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development